chore: Update ed25519-zebra to '4' #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 62.12% 62.33% +0.20%
==========================================
Files 24 24
Lines 895 884 -11
Branches 214 215 +1
==========================================
- Hits 556 551 -5
+ Misses 196 189 -7
- Partials 143 144 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ed25519-zebra 3.1 is using a version of
hashbrownthat usesahashthat fails to build in rust nightly 1.78.0. Updating to edd25519-zebra >= 4 uses a newer version ofhashbrown, and subsequently,ahash, that no longer has this issue.ed25519-zebra recommends broadly targeting the major version
"4".cargo +nightly testnow passes with this change.Essentially a rebased #110
Link to issue
Please add a link to any relevant issues/tickets.
Type of change
The key types are public in ucan-key-support, so using both ucan-key-support and ed25519-zebra requires the two to be in sync.